Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(analyzer): use enumflags2 #3230

Merged
merged 3 commits into from
Jun 18, 2024
Merged

refactor(analyzer): use enumflags2 #3230

merged 3 commits into from
Jun 18, 2024

Conversation

ematipico
Copy link
Member

Summary

Part of #3157

Removes bit_flags from biome_analyze, and adds enumflags2.

The usage of this new crate is different from bit_flags, hence I created a few utilities to make the creation of the flags a bit better.

Test Plan

The current CI should pass

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages labels Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50226 50226 0
Passed 49119 49119 0
Failed 1107 1107 0
Panics 0 0 0
Coverage 97.80% 97.80% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6532 6532 0
Passed 2084 2084 0
Failed 4448 4448 0
Panics 0 0 0
Coverage 31.90% 31.90% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18227 18227 0
Passed 13967 13967 0
Failed 4260 4260 0
Panics 0 0 0
Coverage 76.63% 76.63% 0.00%

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3230 will not alter performance

Comparing refactor/rule-categories (0b8d4c6) with main (e8c75e3)

Summary

✅ 90 untouched benchmarks

@ematipico ematipico merged commit 42bc279 into main Jun 18, 2024
16 checks passed
@ematipico ematipico deleted the refactor/rule-categories branch June 18, 2024 06:24
@ramzimalhas ramzimalhas mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 28, 2024
Open
Open
This was referenced Sep 9, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendjr arendjr arendjr approved these changes

Assignees
No one assigned
Labels
A-CLI Area: CLI A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ematipico @arendjr